Bug 38204

Summary: REGRESSION(r58261): webkit-patch edit-changelogs is broken
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2010-04-27 10:40:25 PDT
REGRESSION(r58261): webkit-patch edit-changelogs is broken
Attachments
Patch (3.84 KB, patch)
2010-04-27 10:42 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-27 10:42:18 PDT
Created attachment 54429 [details] Patch
Ojan Vafai
Comment 2 2010-04-27 11:25:06 PDT
Comment on attachment 54429 [details] Patch Sorry, I thought I caught all the cases that needed this. Putting this in AbstractStep is much better.
Eric Seidel (no email)
Comment 3 2010-04-27 11:58:07 PDT
Comment on attachment 54429 [details] Patch To quote someone I know: "Where are the tests? r-".
Adam Barth
Comment 4 2010-04-27 12:00:14 PDT
Comment on attachment 54429 [details] Patch The tests will be in https://bugs.webkit.org/show_bug.cgi?id=38209
Adam Barth
Comment 5 2010-04-27 13:14:18 PDT
Comment on attachment 54429 [details] Patch Will land by hand.
Adam Barth
Comment 6 2010-04-27 13:22:32 PDT
Committed r58328: <http://trac.webkit.org/changeset/58328>
Note You need to log in before you can comment on or make changes to this bug.