Bug 38204

Summary:

REGRESSION(r58261): webkit-patch edit-changelogs is broken

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+

Description Adam Barth 2010-04-27 10:40:25 PDT

REGRESSION(r58261): webkit-patch edit-changelogs is broken

Comment 1 Adam Barth 2010-04-27 10:42:18 PDT

Created attachment 54429 [details]
Patch

Comment 2 Ojan Vafai 2010-04-27 11:25:06 PDT

Comment on attachment 54429 [details]
Patch

Sorry, I thought I caught all the cases that needed this. Putting this in AbstractStep is much better.

Comment 3 Eric Seidel (no email) 2010-04-27 11:58:07 PDT

Comment on attachment 54429 [details]
Patch

To quote someone I know: "Where are the tests? r-".

Comment 4 Adam Barth 2010-04-27 12:00:14 PDT

Comment on attachment 54429 [details]
Patch

The tests will be in https://bugs.webkit.org/show_bug.cgi?id=38209

Comment 5 Adam Barth 2010-04-27 13:14:18 PDT

Comment on attachment 54429 [details]
Patch

Will land by hand.

Comment 6 Adam Barth 2010-04-27 13:22:32 PDT

Committed r58328: <http://trac.webkit.org/changeset/58328>