Bug 38177

Summary:

Add specialized thunks for a char code related string functions

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mjs: review+

Description Oliver Hunt 2010-04-26 23:57:50 PDT

Add specialized thunks for a char code related string functions

Comment 1 Oliver Hunt 2010-04-27 00:00:26 PDT

Created attachment 54389 [details]
Patch

Comment 2 Maciej Stachowiak 2010-04-27 00:14:35 PDT

Comment on attachment 54389 [details]
Patch

JavaScriptCore/ChangeLog:17
 +          (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
I know this comment is a bit late, but I think the term "thunk" for these doesn't match standard usage. Doesn't match any of the definitions here: http://en.wikipedia.org/wiki/Thunk
I can't think of an accurate but brief term offhand. Maybe "Stub", though we also have JIT stubs.

Patch otherwise looks correct. Please double-check that there is really a perf gain, if so, r=me.

Comment 3 Oliver Hunt 2010-04-27 11:17:48 PDT

Committed r58317: <http://trac.webkit.org/changeset/58317>

Comment 4 WebKit Review Bot 2010-04-27 11:42:30 PDT

http://trac.webkit.org/changeset/58317 might have broken Qt Linux ARMv5 Release