Bug 38173

Summary: Fix JSC binding generation to match webkit style
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, commit-queue: commit-queue-

Eric Seidel (no email)
Reported 2010-04-26 22:48:15 PDT
Fix JSC binding generation to match webkit style
Attachments
Patch (11.69 KB, patch)
2010-04-26 22:50 PDT, Eric Seidel (no email) 		abarth: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-04-26 22:50:43 PDT
Created attachment 54384 [details] Patch
Adam Barth
Comment 2 2010-04-26 23:03:31 PDT
Comment on attachment 54384 [details] Patch You should add more test coverage for the cases we're not testing yet.
WebKit Commit Bot
Comment 3 2010-04-27 00:47:56 PDT
Comment on attachment 54384 [details] Patch Rejecting patch 54384 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 patching file WebCore/ChangeLog patching file WebCore/bindings/scripts/CodeGeneratorJS.pm patching file WebCore/bindings/scripts/test/JS/JSTestObj.cpp Hunk #1 succeeded at 46 (offset 2 lines). Hunk #2 succeeded at 56 (offset 2 lines). Hunk #3 FAILED at 130. 1 out of 3 hunks FAILED -- saving rejects to file WebCore/bindings/scripts/test/JS/JSTestObj.cpp.rej patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/run-bindings-tests Full output: http://webkit-commit-queue.appspot.com/results/1917010
Eric Seidel (no email)
Comment 4 2010-05-02 19:32:36 PDT
Attachment 54384 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Eric Seidel (no email)
Comment 5 2010-05-07 20:17:03 PDT
Committed r58992: <http://trac.webkit.org/changeset/58992>
Note You need to log in before you can comment on or make changes to this bug.