| Summary: | Add testing infrastructure for JSC bindings generator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, yaar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2010-04-26 21:31:19 PDT
Created attachment 54379 [details]
Patch
Comment on attachment 54379 [details]
Patch
WebCore/ChangeLog:67
+ * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp.
It's unclear to me why these moved from v8/test to test/v8. Seems slightly silly.
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:6
+ modify it under the terms of the GNU Library General Public
Why are we generating LGPL code? Also seems silly. But that's something to fix later.
WebKitTools/Scripts/run-bindings-tests:46
+ # place holder for defines (generate-bindings.pl requirement)
This comment is no longer valid.
WebKitTools/Scripts/run-bindings-tests:118
+ # FIXME: Add ObjC
COM too? Or did we kill COM?
WebKitTools/Scripts/run-bindings-tests:123
+ os.path.join('WebCore', 'bindings', 'scripts', 'test'), # Input dir
I would have put the big joins into little local vars first.
Looks OK.
|