Bug 38159

Summary: [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs
Product: WebKit Reporter: Daniel Cheng <dcheng@chromium.org>
Component: PlatformAssignee: Nobody <webkit-unassigned@lists.webkit.org>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue@webkit.org, jianli@chromium.org, webkit.review.bot@gmail.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Windows 7   
Attachments:
Description Flags
Fix for ChromiumDataObject::setURL
none
Fix for ChromiumDataObject::setURL
none
Fix for ChromiumDataObject::setURL
none
Fix for ChromiumDataObject::setURL none

Description From 2010-04-26 17:58:04 PST
Created an attachment (id=54357) [details]
Fix for ChromiumDataObject::setURL

This wouldn't be a problem except that it appends URLs to an internal list. The fix should be to not append empty URLs; otherwise, asserts in getData will be triggered.
------- Comment #1 From 2010-04-26 18:02:52 PST -------
Attachment 54357 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/chromium/ChromiumDataObject.h:80:  Tab found; better to use spaces  [whitespace/tab] [1]
WebCore/platform/chromium/ChromiumDataObject.h:81:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #2 From 2010-04-26 18:04:46 PST -------
Created an attachment (id=54359) [details]
Fix for ChromiumDataObject::setURL

Removed the tabs that VS inserted.
------- Comment #3 From 2010-04-26 18:15:31 PST -------
Created an attachment (id=54363) [details]
Fix for ChromiumDataObject::setURL

Move the return, per the discussion.
------- Comment #4 From 2010-04-26 18:17:38 PST -------
Created an attachment (id=54365) [details]
Fix for ChromiumDataObject::setURL

Fix ChangeLog
------- Comment #5 From 2010-04-26 18:20:25 PST -------
(From update of attachment 54365 [details])
r=me
------- Comment #6 From 2010-04-26 20:07:46 PST -------
(From update of attachment 54365 [details])
Clearing flags on attachment: 54365

Committed r58280: <http://trac.webkit.org/changeset/58280>
------- Comment #7 From 2010-04-26 20:07:51 PST -------
All reviewed patches have been landed.  Closing bug.