| Summary: | [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Cheng <dcheng> | ||||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, jianli, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Attachments: |
|
||||||||||||
Attachment 54357 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/chromium/ChromiumDataObject.h:80: Tab found; better to use spaces [whitespace/tab] [1]
WebCore/platform/chromium/ChromiumDataObject.h:81: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 54359 [details]
Fix for ChromiumDataObject::setURL
Removed the tabs that VS inserted.
Created attachment 54363 [details]
Fix for ChromiumDataObject::setURL
Move the return, per the discussion.
Created attachment 54365 [details]
Fix for ChromiumDataObject::setURL
Fix ChangeLog
Comment on attachment 54365 [details]
Fix for ChromiumDataObject::setURL
r=me
Comment on attachment 54365 [details] Fix for ChromiumDataObject::setURL Clearing flags on attachment: 54365 Committed r58280: <http://trac.webkit.org/changeset/58280> All reviewed patches have been landed. Closing bug. |
Created attachment 54357 [details] Fix for ChromiumDataObject::setURL This wouldn't be a problem except that it appends URLs to an internal list. The fix should be to not append empty URLs; otherwise, asserts in getData will be triggered.