Summary: | Need to support more efficient dispatch of lightweight builtins | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Oliver Hunt
2010-04-26 17:44:06 PDT
Created attachment 54369 [details]
Patch
Attachment 54369 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/runtime/Lookup.h:80: More than one command on the same line [whitespace/newline] [4]
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:1707: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
JavaScriptCore/jit/JSInterfaceJIT.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
JavaScriptCore/jit/SpecializedThunkJIT.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
JavaScriptCore/jit/ThunkGenerators.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 20 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 54369 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" > exit_code: 1 > JavaScriptCore/runtime/Lookup.h:80: More than one command on the same line > [whitespace/newline] [4] > JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:1707: > One or more unexpected \r (^M) found; better to use only a \n > [whitespace/carriage_return] [1] > Suppressing further [whitespace/carriage_return] reports for this file. > JavaScriptCore/jit/JSInterfaceJIT.h:38: Code inside a namespace should not be > indented. [whitespace/indent] [4] > JavaScriptCore/jit/SpecializedThunkJIT.h:37: Code inside a namespace should > not be indented. [whitespace/indent] [4] > JavaScriptCore/jit/ThunkGenerators.h:33: Code inside a namespace should not be > indented. [whitespace/indent] [4] > Total errors found: 20 in 27 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. style bot is wrong here -- code inside a namespace in a .h file should be indented. \r should be used in the vcproj, lookup.h has an assert as the first command which is also allowed. Comment on attachment 54369 [details]
Patch
Please split this patch into two, and land the file moves separately.
Also, please remove the friend from StringImpl - add a static method to access the offset of m_data instead.
Committed r58286: <http://trac.webkit.org/changeset/58286> |