Bug 38126

Summary: [Chromium] Create new baseline for caret-rtl-2
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Xiaomei Ji <xji>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, jorlow, xji
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 38109    
Attachments:
Description Flags
Patch none

Jeremy Orlow
Reported 2010-04-26 07:17:14 PDT
[Chromium] Create new baseline for caret-rtl-2
Attachments
Patch (16.84 KB, patch)
2010-04-26 07:24 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-04-26 07:24:54 PDT
Created attachment 54296 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-04-26 07:36:25 PDT
Xiaomei, can you check to see if the baseline is right?
Xiaomei Ji
Comment 3 2010-04-26 09:54:07 PDT
Yes. that is correct. The caret is at the very left after the fix of issue 25319.
Jeremy Orlow
Comment 4 2010-04-26 09:57:47 PDT
Is the (non-chromium) baseline correct (and thus we should land this patch) or should it have been updated as well (and thus you should generate a proper baseline and we'll throw this patch away)?
Xiaomei Ji
Comment 5 2010-04-26 10:19:04 PDT
Sorry for the trouble. I should re-baseline several tests including this one.
Jeremy Orlow
Comment 6 2010-04-26 10:25:59 PDT
No problem. Was just trying to understand the situation. I'll turn the bug over to you for generating baselines?
Xiaomei Ji
Comment 7 2010-04-26 16:30:51 PDT
Surprisingly, this test does not fail in webkit mac debug and release build even turn on --tolerance=0. So, we will need to land this patch for chromium only. Also, the test fails in chromium windows too. I have not tested in Linux yet. Then, should we create a new baseline for windows and linux too?
Jeremy Orlow
Comment 8 2010-04-27 02:59:04 PDT
It's been marked as something that will always fail on Win/Linux. Please look into why this is. It'd be great if we could add test coverage just by turning on an existing test! Anyway, Dimitri, can you r+ this?
Dimitri Glazkov (Google)
Comment 9 2010-04-27 07:30:56 PDT
Comment on attachment 54296 [details] Patch ok.
WebKit Commit Bot
Comment 10 2010-04-27 16:03:09 PDT
Comment on attachment 54296 [details] Patch Clearing flags on attachment: 54296 Committed r58348: <http://trac.webkit.org/changeset/58348>
WebKit Commit Bot
Comment 11 2010-04-27 16:03:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.