| Summary: | [Chromium] Create new baseline for caret-rtl-2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Orlow <jorlow> | ||||
| Component: | New Bugs | Assignee: | Xiaomei Ji <xji> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dglazkov, jorlow, xji | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 38109 | ||||||
| Attachments: |
|
||||||
|
Description
Jeremy Orlow
2010-04-26 07:17:14 PDT
Created attachment 54296 [details]
Patch
Xiaomei, can you check to see if the baseline is right? Yes. that is correct. The caret is at the very left after the fix of issue 25319. Is the (non-chromium) baseline correct (and thus we should land this patch) or should it have been updated as well (and thus you should generate a proper baseline and we'll throw this patch away)? Sorry for the trouble. I should re-baseline several tests including this one. No problem. Was just trying to understand the situation. I'll turn the bug over to you for generating baselines? Surprisingly, this test does not fail in webkit mac debug and release build even turn on --tolerance=0. So, we will need to land this patch for chromium only. Also, the test fails in chromium windows too. I have not tested in Linux yet. Then, should we create a new baseline for windows and linux too? It's been marked as something that will always fail on Win/Linux. Please look into why this is. It'd be great if we could add test coverage just by turning on an existing test! Anyway, Dimitri, can you r+ this? Comment on attachment 54296 [details]
Patch
ok.
Comment on attachment 54296 [details] Patch Clearing flags on attachment: 54296 Committed r58348: <http://trac.webkit.org/changeset/58348> All reviewed patches have been landed. Closing bug. |