Summary: | [Android] The touchmove delta used in basic-single-touch-events.html is too small for Android | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ben Murdoch <benm> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | android-webkit-unforking, commit-queue, gdk, hausmann, jorlow | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Android | ||||||
OS: | Android | ||||||
Attachments: |
|
Description
Ben Murdoch
2010-04-23 12:21:33 PDT
Created attachment 54181 [details]
Proposed Patch
Comment on attachment 54181 [details]
Proposed Patch
Might it be a good idea to change one of the values so that they're not both 50 and/or 20?
(In reply to comment #2) > (From update of attachment 54181 [details]) > Might it be a good idea to change one of the values so that they're not both 50 > and/or 20? I could do ... although all the analysis I've done I've always looked at the x and y as a pair, so it was only useful to make the x,y pair distinct from other pairs. Unless you feel strongly I think we can just leave as-is. Thanks, Ben I r+'ed it because I was OK with it in its current state. Just a suggestion. Comment on attachment 54181 [details]
Proposed Patch
Great, thanks. Setting cq+.
Comment on attachment 54181 [details] Proposed Patch Clearing flags on attachment: 54181 Committed r58208: <http://trac.webkit.org/changeset/58208> All reviewed patches have been landed. Closing bug. |