Bug 38051

Summary:

[GTK] Fix out of source build failure

Product:

WebKit

Reporter:

Geoff Levand <geoff.levand>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
patch v1	none
patch v2	none
patch v3	none
patch v4	none

Geoff Levand

Reported 2010-04-23 10:35:53 PDT

Add a preprocessor include path for generated GTK header files. Fixes build errors like these when building GTK out of source: webkit.h: error: webkit/webkitversion.h: No such file or directory -Geoff

Attachments
patch v1 (1.06 KB, patch) 2010-04-23 10:39 PDT, Geoff Levand	no flags	Details Formatted Diff Diff
patch v2 (1.00 KB, patch) 2010-04-23 11:00 PDT, Geoff Levand	no flags	Details Formatted Diff Diff
patch v3 (874 bytes, patch) 2010-04-23 11:12 PDT, Geoff Levand	no flags	Details Formatted Diff Diff
patch v4 (1014 bytes, patch) 2010-04-23 11:38 PDT, Geoff Levand	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Geoff Levand

Comment 1 2010-04-23 10:39:15 PDT

Created attachment 54171 [details] patch v1

Geoff Levand

Comment 2 2010-04-23 11:00:53 PDT

Created attachment 54176 [details] patch v2

WebKit Review Bot

Comment 3 2010-04-23 11:03:27 PDT

Attachment 54176 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoff Levand

Comment 4 2010-04-23 11:12:41 PDT

Created attachment 54177 [details] patch v3

WebKit Review Bot

Comment 5 2010-04-23 11:15:13 PDT

Attachment 54177 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoff Levand

Comment 6 2010-04-23 11:38:37 PDT

Created attachment 54178 [details] patch v4

Eric Seidel (no email)

Comment 7 2010-05-02 19:07:07 PDT

Comment on attachment 54178 [details] patch v4 OK... rs=me.

Eric Seidel (no email)

Comment 8 2010-05-02 19:08:19 PDT

Comment on attachment 54178 [details] patch v4 I think what you all are actually looking for is forwarding headers. See WebCore/ForwardingHeaders as examples. Or at least that's how this sort of problem of internal header paths vs. external header paths are solved on Mac. But this looks OK too.

WebKit Commit Bot

Comment 9 2010-05-02 19:21:44 PDT

Comment on attachment 54178 [details] patch v4 Clearing flags on attachment: 54178 Committed r58664: <http://trac.webkit.org/changeset/58664>

WebKit Commit Bot

Comment 10 2010-05-02 19:21:50 PDT

All reviewed patches have been landed. Closing bug.

Xan Lopez

Comment 11 2010-05-03 02:03:15 PDT

(In reply to comment #0) > Add a preprocessor include path for generated GTK header files. > Fixes build errors like these when building GTK out of source: > > webkit.h: error: webkit/webkitversion.h: No such file or directory > > -Geoff When you say out of source you simply mean using a build directory like WebKitBuild? It's strange that you say it does not work for you, since we all use that every day. What is your environment like exactly?

Geoff Levand

Comment 12 2010-05-03 08:49:43 PDT

Hi, (In reply to comment #11) > (In reply to comment #0) > > Add a preprocessor include path for generated GTK header files. > > Fixes build errors like these when building GTK out of source: > > > > webkit.h: error: webkit/webkitversion.h: No such file or directory > > When you say out of source you simply mean using a build directory like > WebKitBuild? It's strange that you say it does not work for you, since we all > use that every day. What is your environment like exactly? This is a common automake makefile bug. Something like this will hit it: git clone git://git.webkit.org/WebKit.git cd WebKit ./autogen.sh mkdir ../build cd ../build ../Webkit/configure make -Geoff

Xan Lopez

Comment 13 2010-05-03 09:00:15 PDT

(In reply to comment #12) > This is a common automake makefile bug. Something like this > will hit it: > > git clone git://git.webkit.org/WebKit.git > cd WebKit > ./autogen.sh > mkdir ../build > cd ../build > ../Webkit/configure > make > > -Geoff Yeah, we all use something like that and this is the first time I hear from anyone of a build failure. That's why I was wondering of the exact details of your environment.

Note You need to log in before you can comment on or make changes to this bug.