Bug 38043

Summary:

Web Inspector: Profiler: A status item is required when record button is pressed.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mnaganov, pfeldman, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	pfeldman: review+

Ilya Tikhonovsky

Reported 2010-04-23 05:01:47 PDT

%SUBJ%

Attachments
proposed patch (3.86 KB, patch) 2010-04-30 04:49 PDT, Mikhail Naganov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2010-04-30 04:49:11 PDT

Created attachment 54793 [details] proposed patch

Pavel Feldman

Comment 2 2010-04-30 07:56:27 PDT

Comment on attachment 54793 [details] proposed patch WebCore/inspector/front-end/ProfilesPanel.js:328 + if (this._profiles[i].uid == profile.uid) { === ?

Mikhail Naganov

Comment 3 2010-05-04 03:04:44 PDT

Manually committed as http://trac.webkit.org/changeset/58745. 2010-05-04 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Display "Recording..." item when recording an user-initiated CPU profile. https://bugs.webkit.org/show_bug.cgi?id=38043 * English.lproj/localizedStrings.js: * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile): * inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):

Note You need to log in before you can comment on or make changes to this bug.