Bug 38037

Summary: remove 'with' from http_server.py
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, cjerdonek, dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2010-04-23 01:14:02 PDT
remove 'with' from http_server.py
Attachments
Patch (1.31 KB, patch)
2010-04-23 01:14 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (10.50 KB, patch)
2010-04-23 01:41 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-04-23 01:14:51 PDT
Created attachment 54138 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-23 01:31:17 PDT
Comment on attachment 54138 [details] Patch Looks good to me. Thanks for fixing.
Tony Chang
Comment 3 2010-04-23 01:41:49 PDT
Created attachment 54139 [details] Patch
Eric Seidel (no email)
Comment 4 2010-04-23 01:46:28 PDT
Comment on attachment 54139 [details] Patch I think this is a dangerous road we shouldn't really go down. I'm in favor of unhinging these issues. But given this number of changes these bots are guarenteed to break again days from now. How much work is it to upgrade them? I thought all was needed to upgrade folks was to have them re-run glient after deleting some file? Dirk posted instructions on chromium-dev at some point.
Tony Chang
Comment 5 2010-04-23 02:06:20 PDT
Moving the patch over since this should be on bug 38031 *** This bug has been marked as a duplicate of bug 38031 ***
Note You need to log in before you can comment on or make changes to this bug.