Bug 38028

Summary: [chromium] build-webkit --chromium should build release by default
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2010-04-22 20:42:13 PDT
[chromium] build-webkit --chromium should build release by default
Attachments
Patch (2.74 KB, patch)
2010-04-22 20:43 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2010-04-23 00:37 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-04-22 20:43:39 PDT
Created attachment 54125 [details] Patch
Adam Barth
Comment 2 2010-04-23 00:33:32 PDT
Comment on attachment 54125 [details] Patch WebKitTools/Scripts/webkitdirs.pm:  + Why remove this random line? I don't read perl, but this looks plausible. Leaving it for a perl hacker though.
Tony Chang
Comment 3 2010-04-23 00:34:39 PDT
(In reply to comment #2) > (From update of attachment 54125 [details]) > WebKitTools/Scripts/webkitdirs.pm:  > + > Why remove this random line? Oops, that's an accident.
Tony Chang
Comment 4 2010-04-23 00:37:03 PDT
Created attachment 54137 [details] Patch
David Levin
Comment 5 2010-04-26 17:31:21 PDT
Why does this only change the Chromium OSX builds (and not the Windows or Linux builds)?
Tony Chang
Comment 6 2010-04-26 17:47:13 PDT
(In reply to comment #5) > Why does this only change the Chromium OSX builds (and not the Windows or Linux > builds)? Windows and Linux already do the right thing in buildChromiumMakefile and buildChromiumVisualStudioProject.
Tony Chang
Comment 7 2010-04-26 18:27:06 PDT
Comment on attachment 54137 [details] Patch Clearing flags on attachment: 54137 Committed r58275: <http://trac.webkit.org/changeset/58275>
Tony Chang
Comment 8 2010-04-26 18:27:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.