Bug 38026

Summary: [Qt] Disable Netscape plugin support for minimal configuration
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2010-04-22 20:12:01 PDT
Now that we have a "minimal" buildbot for QtWebKit and NPAPI-less configuration is often broken, it could be a real win to disable NPAPI for minimal configuration so that we get an immediate build-break.
Attachments
proposed patch (2.22 KB, patch)
2010-04-22 20:27 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-04-22 20:27:10 PDT
Created attachment 54124 [details] proposed patch This patch make the minimal configuration option visible in the Qt make system, which could be useful later as well. An alternative to this patch is to create a global "npapi support" build option to build-webkit, but as many ports do not support this option,I felt it is best to do it for the Qt port only.
WebKit Commit Bot
Comment 2 2010-04-23 11:31:48 PDT
Comment on attachment 54124 [details] proposed patch Clearing flags on attachment: 54124 Committed r58178: <http://trac.webkit.org/changeset/58178>
WebKit Commit Bot
Comment 3 2010-04-23 11:31:54 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-04-23 11:43:42 PDT
http://trac.webkit.org/changeset/58178 might have broken Qt Linux Release minimal
Tor Arne Vestbø
Comment 5 2010-04-23 12:14:13 PDT
Any reason you didn't add it as a normal enable/disable option to build-webkit so that the --minimal option would do this automatically?
Tor Arne Vestbø
Comment 6 2010-04-23 12:17:14 PDT
(In reply to comment #1) > An alternative to this patch is to create a global "npapi support" build option > to build-webkit, but as many ports do not support this option,I felt it is best > to do it for the Qt port only. Never mind, didn't see this comment. If we can I'd rather we move this to a global option if possible.
Laszlo Gombos
Comment 7 2010-04-23 14:06:52 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/58178 might have broken Qt Linux Release > minimal Dependency problems with the bot, bug filed - bug 38054
Note You need to log in before you can comment on or make changes to this bug.