Bug 38013

Summary: Add an additionalFeatures vector onto WindowFeatures
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rafael Weinstein
Reported 2010-04-22 16:52:17 PDT
This patch adds a vector of strings to WindowFeatures which are captured if they are not explicitly observed in WindowFeatures and evaluate to set (value=="yes"). The motivation for this is so that clients (chromium currently) can capture experimental window.open() features.
Attachments
Patch (2.52 KB, patch)
2010-04-22 16:55 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (5.89 KB, patch)
2010-04-22 16:59 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (5.98 KB, patch)
2010-04-23 10:46 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2010-04-22 16:55:08 PDT
Created attachment 54108 [details] Patch
Rafael Weinstein
Comment 2 2010-04-22 16:59:34 PDT
Created attachment 54109 [details] Patch
Darin Fisher (:fishd, Google)
Comment 3 2010-04-23 00:11:31 PDT
Comment on attachment 54109 [details] Patch This is all good, except: WebKit/chromium/ChangeLog:9 > + Need a short description and bug URL (OOPS!) Please delete this line. Replace it with a link to this bug. WebCore/ChangeLog:9 > + Please include a link to the bug here. R=me otherwise. CQ- because this patch needs some tweaks before it can be committed.
Rafael Weinstein
Comment 4 2010-04-23 10:46:59 PDT
Created attachment 54174 [details] Patch
Rafael Weinstein
Comment 5 2010-04-23 10:47:44 PDT
bug link added to both ChangeLogs
WebKit Commit Bot
Comment 6 2010-04-23 18:05:10 PDT
Comment on attachment 54174 [details] Patch Clearing flags on attachment: 54174 Committed r58205: <http://trac.webkit.org/changeset/58205>
WebKit Commit Bot
Comment 7 2010-04-23 18:05:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.