Bug 38007

Summary: REGRESSION(r58110): Caused an internal compiler error on Qt (Requested by abarth on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 37948    
Attachments:
Description Flags
ROLLOUT of r58110 none

WebKit Review Bot
Reported 2010-04-22 14:21:03 PDT
http://trac.webkit.org/changeset/58110 broke the build: Caused an internal compiler error on Qt (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r58110 (1.17 KB, patch)
2010-04-22 14:21 PDT, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2010-04-22 14:21:20 PDT
Created attachment 54095 [details] ROLLOUT of r58110 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
Adam Barth
Comment 2 2010-04-22 14:21:52 PDT
Comment on attachment 54095 [details] ROLLOUT of r58110 go go gadget commit queue
Steve Block
Comment 4 2010-04-22 14:44:24 PDT
I admit that the waterfall makes it look like my change is at fault, but it seems hard to believe. All my change does is remove an OS(ANDROID) guard. Plus it built fine on the Qt try bot (see Bug 37948). Is there a Qt developer I can contact to see if they can reproduce the build problem locally?
WebKit Commit Bot
Comment 5 2010-04-22 14:44:54 PDT
Comment on attachment 54095 [details] ROLLOUT of r58110 Clearing flags on attachment: 54095 Committed r58118: <http://trac.webkit.org/changeset/58118>
WebKit Commit Bot
Comment 6 2010-04-22 14:44:59 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2010-04-22 14:46:47 PDT
> Is there a Qt developer I can contact to see if they can reproduce the build > problem locally? I wouldn't stress too much about it. If the error is still there after the rollout, we can blame the bot and roll your patch back in.
Steve Block
Comment 8 2010-04-22 15:32:40 PDT
My change has now been rolled out but the Qt build still fails in the same way (http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/461) Adam, are you happy for me to put the change back in?
Adam Barth
Comment 9 2010-04-22 15:43:23 PDT
> Adam, are you happy for me to put the change back in? Yep! Thanks for you patience. You can either land it yourself or we can have the bot take care of it.
Note You need to log in before you can comment on or make changes to this bug.