Bug 38004

Summary: The new review tools shouldn't clear the comment box automatically
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-04-22 13:40:12 PDT
The new review tools shouldn't clear the comment box automatically
Attachments
Patch (2.39 KB, patch)
2010-04-22 13:41 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-22 13:41:33 PDT
Created attachment 54092 [details] Patch
Darin Adler
Comment 2 2010-04-22 17:21:14 PDT
Comment on attachment 54092 [details] Patch Seems OK. Also seems it would be best to clear the comments only when the entire comment area is untouched to avoid clobbering things people typed. Lets just keep experimenting, I guess. r=me
Adam Barth
Comment 3 2010-04-22 21:25:51 PDT
Comment on attachment 54092 [details] Patch Yeah, I think we should get the minimum viable product and then iterate from there. Sorry to have disrupted your workflow.
WebKit Commit Bot
Comment 4 2010-04-22 21:48:33 PDT
Comment on attachment 54092 [details] Patch Clearing flags on attachment: 54092 Committed r58148: <http://trac.webkit.org/changeset/58148>
WebKit Commit Bot
Comment 5 2010-04-22 21:48:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.