Bug 38004 - The new review tools shouldn't clear the comment box automatically
: The new review tools shouldn't clear the comment box automatically
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-04-22 13:40 PST by
Modified: 2010-04-22 21:48 PST (History)


Attachments
Patch (2.39 KB, patch)
2010-04-22 13:41 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-04-22 13:40:12 PST
The new review tools shouldn't clear the comment box automatically
------- Comment #1 From 2010-04-22 13:41:33 PST -------
Created an attachment (id=54092) [details]
Patch
------- Comment #2 From 2010-04-22 17:21:14 PST -------
(From update of attachment 54092 [details])
Seems OK. Also seems it would be best to clear the comments only when the entire comment area is untouched to avoid clobbering things people typed. Lets just keep experimenting, I guess. r=me
------- Comment #3 From 2010-04-22 21:25:51 PST -------
(From update of attachment 54092 [details])
Yeah, I think we should get the minimum viable product and then iterate from there.  Sorry to have disrupted your workflow.
------- Comment #4 From 2010-04-22 21:48:33 PST -------
(From update of attachment 54092 [details])
Clearing flags on attachment: 54092

Committed r58148: <http://trac.webkit.org/changeset/58148>
------- Comment #5 From 2010-04-22 21:48:38 PST -------
All reviewed patches have been landed.  Closing bug.