Bug 38004 - The new review tools shouldn't clear the comment box automatically
: The new review tools shouldn't clear the comment box automatically
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-22 13:40 PDT by Adam Barth
Modified: 2010-04-22 21:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2010-04-22 13:41 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-22 13:40:12 PDT
The new review tools shouldn't clear the comment box automatically
Comment 1 Adam Barth 2010-04-22 13:41:33 PDT
Created attachment 54092 [details]
Patch
Comment 2 Darin Adler 2010-04-22 17:21:14 PDT
Comment on attachment 54092 [details]
Patch

Seems OK. Also seems it would be best to clear the comments only when the entire comment area is untouched to avoid clobbering things people typed. Lets just keep experimenting, I guess. r=me
Comment 3 Adam Barth 2010-04-22 21:25:51 PDT
Comment on attachment 54092 [details]
Patch

Yeah, I think we should get the minimum viable product and then iterate from there.  Sorry to have disrupted your workflow.
Comment 4 WebKit Commit Bot 2010-04-22 21:48:33 PDT
Comment on attachment 54092 [details]
Patch

Clearing flags on attachment: 54092

Committed r58148: <http://trac.webkit.org/changeset/58148>
Comment 5 WebKit Commit Bot 2010-04-22 21:48:38 PDT
All reviewed patches have been landed.  Closing bug.