Bug 38002

Summary: Add rudimentary statistics gathering for WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch andersca: review+

Sam Weinig
Reported 2010-04-22 13:18:16 PDT
Add rudimentary statistics gathering for WebKit2 and some MiniBrowser hacking to show it off.
Attachments
patch (42.23 KB, patch)
2010-04-22 13:20 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-04-22 13:20:20 PDT
Created attachment 54090 [details] patch
WebKit Review Bot
Comment 2 2010-04-22 13:26:51 PDT
Attachment 54090 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/WebPageProxy.cpp:43: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/WebPageNamespace.cpp:31: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/WebContext.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-04-22 13:54:57 PDT
Comment on attachment 54090 [details] patch r=me
Sam Weinig
Comment 4 2010-04-22 13:57:16 PDT
Fixed in r58117.
Adam Barth
Comment 5 2010-04-23 18:32:38 PDT
Did these style errors get addressed before landing? Are the errors false positives?
Sam Weinig
Comment 6 2010-04-23 21:06:11 PDT
(In reply to comment #5) > Did these style errors get addressed before landing? Are the errors false > positives? The issue is that I am paragraphing the #includes, so the script is a little confused. I don't think we have a style rule for this, and it is perhaps something I just should not be doing.
Note You need to log in before you can comment on or make changes to this bug.