Summary: | [chromium] fix ImageDiff compile on windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Tony Chang
2010-04-22 00:36:17 PDT
Created attachment 54035 [details]
Patch
Comment on attachment 54035 [details] Patch This is a build fix. So I think we may commit it without review. > --- a/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp > +++ b/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp > @@ -39,12 +39,15 @@ > #include "gfx/codec/png_codec.h" > #include <algorithm> > #include <stdio.h> > -#include <string.h> > -#include <string> > #include <vector> strcmp() is used. We had better not remove string.h. Created attachment 54039 [details]
Patch
(In reply to comment #2) > (From update of attachment 54035 [details]) > > --- a/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp > > +++ b/WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp > > @@ -39,12 +39,15 @@ > > #include "gfx/codec/png_codec.h" > > #include <algorithm> > > #include <stdio.h> > > -#include <string.h> > > -#include <string> > > #include <vector> > > strcmp() is used. We had better not remove string.h. Good catch. Attempting to land the revised patch now. Committed r58073: <http://trac.webkit.org/changeset/58073> |