Bug 37963

Summary:

Regression: framebufferRenderbuffer crashes with null renderBuffer

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Zhenyao Mo <zmo>

Status:

RESOLVED FIXED

Severity:

Major

CC:

cmarrin, commit-queue, dglazkov, fishd, kbr, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Description Kenneth Russell 2010-04-21 17:24:29 PDT

https://bugs.webkit.org/show_bug.cgi?id=35611 introduced a regression in framebufferRenderbuffer when a null renderBuffer is passed; the null pointer is dereferenced and the WebGLRenderingContext crashes.

Comment 1 Zhenyao Mo 2010-04-21 17:50:58 PDT

Created attachment 54009 [details]
patch

Comment 2 Kenneth Russell 2010-04-21 17:55:15 PDT

Comment on attachment 54009 [details]
patch

Looks good. Thanks for the quick fix.

Comment 3 Dimitri Glazkov (Google) 2010-04-22 09:25:07 PDT

Comment on attachment 54009 [details]
patch

r=me.

Comment 4 WebKit Commit Bot 2010-04-22 10:04:15 PDT

Comment on attachment 54009 [details]
patch

Clearing flags on attachment: 54009

Committed r58103: <http://trac.webkit.org/changeset/58103>

Comment 5 WebKit Commit Bot 2010-04-22 10:04:22 PDT

All reviewed patches have been landed.  Closing bug.