Bug 37948

Summary: [Android] Android should use isfinite, isinf, isnan and signbit from the std namespace
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, android-webkit-unforking, commit-queue, eric, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on: 38007    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Steve Block 2010-04-21 13:42:45 PDT 
http://trac.webkit.org/changeset/54388 updated MathExtras.h to use <cmath> (rather than <math.h>) which provides isfinite, isinf, isnan and signbit in the std namespace. This broke the Android build as Android's version of STL did not at the time provide these functions in the std namespace. The build was fixed with a compile guard around the using declarations in http://trac.webkit.org/changeset/54655.

Android's version of STL now provides these functions in the std namespace, so we can remove the guard around the using declarations.
Comment 1 Steve Block 2010-04-21 13:46:08 PDT 
Created attachment 53986 [details]
Patch
Comment 2 Adam Barth 2010-04-22 12:44:50 PDT 
Comment on attachment 53986 [details]
Patch

ok.
Comment 3 Steve Block 2010-04-22 12:55:51 PDT 
Comment on attachment 53986 [details]
Patch

Clearing flags on attachment: 53986

Committed r58110: <http://trac.webkit.org/changeset/58110>
Comment 4 Steve Block 2010-04-22 12:56:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-04-22 14:17:14 PDT 
http://trac.webkit.org/changeset/58110 might have broken Qt Windows 32-bit Release
Comment 6 Adam Barth 2010-04-22 15:35:51 PDT 
Failure persisted after rollout
Comment 7 Adam Barth 2010-04-22 15:36:06 PDT 
Comment on attachment 53986 [details]
Patch

Relanding.
Comment 8 WebKit Commit Bot 2010-04-22 20:10:56 PDT 
Comment on attachment 53986 [details]
Patch

Clearing flags on attachment: 53986

Committed r58142: <http://trac.webkit.org/changeset/58142>
Comment 9 WebKit Commit Bot 2010-04-22 20:11:03 PDT 
All reviewed patches have been landed.  Closing bug.