Bug 37922

Summary: Lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: SVGAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
URL: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57973%20(6207)/DumpRenderTree-leaks.txt
Attachments:
Description Flags
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter hyatt: review+, hyatt: commit-queue-

Adam Roben (:aroben)
Reported 2010-04-21 07:11:47 PDT
The SnowLeopard leaks bot is showing lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter. I think the bug is in RenderSVGResourceFilter::applyResource, which allocates a FilterData (which holds an SVGFilterBuilder) on the heap, but doesn't destroy it when returning early under error conditions. Using an OwnPtr should fix this easily.
Attachments
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter (1.59 KB, patch)
2010-04-21 07:40 PDT, Adam Roben (:aroben) 		hyatt: review+
hyatt: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-04-21 07:12:28 PDT
<rdar://problem/7888397>
Adam Roben (:aroben)
Comment 2 2010-04-21 07:40:42 PDT
Created attachment 53955 [details] Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
Dave Hyatt
Comment 3 2010-04-21 07:41:23 PDT
Comment on attachment 53955 [details] Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter r=me
Adam Roben (:aroben)
Comment 4 2010-04-21 07:43:07 PDT
Committed r57980: <http://trac.webkit.org/changeset/57980>
Note You need to log in before you can comment on or make changes to this bug.