Bug 37912

Summary: [Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
replaces the ternary operator by an if statement
none
added more comments and removed the changes in xcodeproj
eric: review+
another repro (with automation) none

Description Ryosuke Niwa 2010-04-20 23:32:12 PDT
Qt Linux builds complains about the line 933 of CompositeEditCommand.cpp because it uses ternary operator to initialize RefPtr.
Comment 1 Ryosuke Niwa 2010-04-20 23:36:39 PDT
Created attachment 53922 [details]
replaces the ternary operator by an if statement
Comment 2 Ryosuke Niwa 2010-04-20 23:45:39 PDT
Created attachment 53923 [details]
added more comments and removed the changes in xcodeproj
Comment 3 Eric Seidel (no email) 2010-04-20 23:47:28 PDT
Comment on attachment 53923 [details]
added more comments and removed the changes in xcodeproj

Fantastic!
Comment 4 Ryosuke Niwa 2010-04-21 01:10:41 PDT
Comment on attachment 53923 [details]
added more comments and removed the changes in xcodeproj

Removed from the commit queue since this patch has already been committed.
Comment 5 Ryosuke Niwa 2010-04-21 01:11:40 PDT
Landed in http://trac.webkit.org/changeset/57957.
Comment 6 Hajime Morrita 2010-07-13 04:53:16 PDT
Created attachment 61356 [details]
another repro (with automation)
Comment 7 Hajime Morrita 2010-07-13 04:59:28 PDT
Comment on attachment 61356 [details]
another repro (with automation)

Oops. posted to a wrong bug.