Bug 37912

Summary: [Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
replaces the ternary operator by an if statement
none
added more comments and removed the changes in xcodeproj
eric: review+
another repro (with automation) none

Ryosuke Niwa
Reported 2010-04-20 23:32:12 PDT
Qt Linux builds complains about the line 933 of CompositeEditCommand.cpp because it uses ternary operator to initialize RefPtr.
Attachments
replaces the ternary operator by an if statement (2.48 KB, patch)
2010-04-20 23:36 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
added more comments and removed the changes in xcodeproj (2.04 KB, patch)
2010-04-20 23:45 PDT, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
another repro (with automation) (577 bytes, text/html)
2010-07-13 04:53 PDT, Hajime Morrita 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-04-20 23:36:39 PDT
Created attachment 53922 [details] replaces the ternary operator by an if statement
Ryosuke Niwa
Comment 2 2010-04-20 23:45:39 PDT
Created attachment 53923 [details] added more comments and removed the changes in xcodeproj
Eric Seidel (no email)
Comment 3 2010-04-20 23:47:28 PDT
Comment on attachment 53923 [details] added more comments and removed the changes in xcodeproj Fantastic!
Ryosuke Niwa
Comment 4 2010-04-21 01:10:41 PDT
Comment on attachment 53923 [details] added more comments and removed the changes in xcodeproj Removed from the commit queue since this patch has already been committed.
Ryosuke Niwa
Comment 5 2010-04-21 01:11:40 PDT
Landed in http://trac.webkit.org/changeset/57957.
Hajime Morrita
Comment 6 2010-07-13 04:53:16 PDT
Created attachment 61356 [details] another repro (with automation)
Hajime Morrita
Comment 7 2010-07-13 04:59:28 PDT
Comment on attachment 61356 [details] another repro (with automation) Oops. posted to a wrong bug.
Note You need to log in before you can comment on or make changes to this bug.