Bug 37903

Summary: Added missing #include "Lookup.h" in LUT source files.
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
The patch none

Patrick R. Gansterer
Reported 2010-04-20 17:01:06 PDT
I try to get WebKit built via CMake. When compiling the LUT source files (ArrayPrototype, DatePrototype, ...) I get an error because HashTableValue isn't defined. Some simple includes fixed that problem.
Attachments
The patch (4.43 KB, patch)
2010-04-20 17:01 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-04-20 17:01:59 PDT
Created attachment 53906 [details] The patch
Darin Adler
Comment 2 2010-04-20 17:15:02 PDT
Comment on attachment 53906 [details] The patch > Index: JavaScriptCore/runtime/ArrayPrototype.cpp > =================================================================== > --- JavaScriptCore/runtime/ArrayPrototype.cpp (revision 57939) > +++ JavaScriptCore/runtime/ArrayPrototype.cpp (working copy) > @@ -24,13 +24,13 @@ > #include "config.h" > #include "ArrayPrototype.h" > > -#include "CodeBlock.h" > #include "CachedCall.h" > +#include "CodeBlock.h" > #include "Interpreter.h" > #include "JIT.h" > #include "JSStringBuilder.h" > -#include "ObjectPrototype.h" > #include "Lookup.h" Since ArrayPrototype.h already includes Lookup.h, I don't think ArrayPrototype.cpp needs to include it at all. But this is not an argument against the patch. The reason this does not affect other builds is that most use AllInOneFile.cpp rather than compiling these files separately.
WebKit Commit Bot
Comment 3 2010-04-21 07:09:57 PDT
Comment on attachment 53906 [details] The patch Clearing flags on attachment: 53906 Committed r57978: <http://trac.webkit.org/changeset/57978>
WebKit Commit Bot
Comment 4 2010-04-21 07:10:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.