Bug 37887

Summary: worker-close.html is flaky on slow machines.
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: Tools / TestsAssignee: Dmitry Titov <dimich>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, atwilson, eric, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 37894    
Bug Blocks:    
Attachments:
Description Flags
Patch. abarth: review+, dimich: commit-queue-

Dmitry Titov
Reported 2010-04-20 13:57:23 PDT
The test sends a message to the worker to close and also to reply with a message. Immediately, it sets up a timer for 500ms which will terminate the test. On slow machines, the timer may terminate test before the reply comes from the worker, so the actual dump is one message short. Fix is to start timer after the message comes. Patch coming.
Attachments
Patch. (1.37 KB, patch)
2010-04-20 13:59 PDT, Dmitry Titov 		abarth: review+
dimich: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2010-04-20 13:59:39 PDT
Created attachment 53877 [details] Patch.
Adam Barth
Comment 2 2010-04-20 14:05:24 PDT
Comment on attachment 53877 [details] Patch. Ok. I'm sad that we have to setTimeout at all...
Dmitry Titov
Comment 3 2010-04-20 14:23:36 PDT
Landed: http://trac.webkit.org/changeset/57916
WebKit Review Bot
Comment 4 2010-04-20 14:53:18 PDT
http://trac.webkit.org/changeset/57919 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.