Bug 37876

Summary: [EFL] Update ChromeClientEfl and FrameLoaderClientEfl
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barbieri, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Update ChromeClientEfl.cpp to support the new ChromeClient API
none
Update ChromeClientEfl.cpp to support the new ChromeClient API
none
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes none

Description Leandro Pereira 2010-04-20 11:32:30 PDT
Attached patch updates ChromeClientEfl.{cpp,h} to conform to the new ChromeClient API, by fixing scroll() and implementing invalidate*() methods. Other methods were also implemented/stubbed as necessary (see ChangeLog entry for details).
Comment 1 Leandro Pereira 2010-04-20 11:33:19 PDT
Created attachment 53855 [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API
Comment 2 WebKit Review Bot 2010-04-20 11:35:51 PDT
Attachment 53855 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:367:  Declaration has space between type name and * in Eina_List *selected_filenames  [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:367:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:368:  Declaration has space between type name and * in Eina_List *suggested_filenames  [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:368:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:369:  Declaration has space between type name and * in void *filename  [whitespace/declaration] [3]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Leandro Pereira 2010-04-20 11:46:02 PDT
Created attachment 53859 [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API

Iron out the style errors.
Comment 4 Leandro Pereira 2010-04-22 10:29:43 PDT
Comment on attachment 53859 [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API

Marking this one as obsolete as I'm submitting a newer patch soon.
Comment 5 Leandro Pereira 2010-04-22 10:43:32 PDT
Created attachment 54072 [details]
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes

Attached patch also updates FrameLoaderClient to match recent WebCore API changes.
Comment 6 Gustavo Noronha (kov) 2010-04-22 10:48:11 PDT
Comment on attachment 54072 [details]
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes

OK!
Comment 7 WebKit Commit Bot 2010-04-22 10:57:33 PDT
Comment on attachment 54072 [details]
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes

Clearing flags on attachment: 54072

Committed r58106: <http://trac.webkit.org/changeset/58106>
Comment 8 WebKit Commit Bot 2010-04-22 10:57:39 PDT
All reviewed patches have been landed.  Closing bug.