Summary: | [EFL] Update ChromeClientEfl and FrameLoaderClientEfl | ||
---|---|---|---|
Product: | WebKit | Reporter: | Leandro Pereira <leandro> |
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | barbieri, commit-queue, webkit.review.bot |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: |
Description
Leandro Pereira
2010-04-20 11:32:30 PDT
Created attachment 53855 [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API
Attachment 53855 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:367: Declaration has space between type name and * in Eina_List *selected_filenames [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:367: Use 0 instead of NULL. [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:368: Declaration has space between type name and * in Eina_List *suggested_filenames [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:368: Use 0 instead of NULL. [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:369: Declaration has space between type name and * in void *filename [whitespace/declaration] [3]
Total errors found: 5 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53859 [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API
Iron out the style errors.
Comment on attachment 53859 [details]
Update ChromeClientEfl.cpp to support the new ChromeClient API
Marking this one as obsolete as I'm submitting a newer patch soon.
Created attachment 54072 [details]
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes
Attached patch also updates FrameLoaderClient to match recent WebCore API changes.
Comment on attachment 54072 [details]
Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes
OK!
Comment on attachment 54072 [details] Update ChromeClientEfl and FrameLoaderclient to match recent WebCore API changes Clearing flags on attachment: 54072 Committed r58106: <http://trac.webkit.org/changeset/58106> All reviewed patches have been landed. Closing bug. |