| Summary: | [DRT/Chromium] Fix some unexpected results of editing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, hamaji | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 35902 | ||||||
| Attachments: |
|
||||||
|
Description
Kent Tamura
2010-04-19 23:53:39 PDT
Created attachment 53777 [details]
Patch
Comment on attachment 53777 [details]
Patch
Looks good!
Side note: the corresponding file seems to be src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We have only one startContainer call in the chromium's code so this would be just a typo.
By the way, I think it's nice to have this kind of info in ChangeLog. Could you update the ChangeLog before you land?
(In reply to comment #2) > (From update of attachment 53777 [details]) > Looks good! > > Side note: the corresponding file seems to be > src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We > have only one startContainer call in the chromium's code so this would be just > a typo. > > By the way, I think it's nice to have this kind of info in ChangeLog. Could you > update the ChangeLog before you land? Right. This was my failure during porting test_webview_delegate.cc. I'll update the ChangeLog. Committed r57876: <http://trac.webkit.org/changeset/57876> |