Summary: | Error when running test-webkitpy (webkitpy.layout_tests.run_webkit_tests_unittest.DryrunTest) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cjerdonek, dpranke, eric, hamaji | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Daniel Bates
2010-04-19 21:42:04 PDT
Created attachment 53769 [details] Error message and backtrace For completeness, the output of running WebKitTools/Scripts/test-webkitpy as of r57867. Created attachment 53772 [details]
Patch
grr. some combination of git, webkit-patch, and my own stupidity screwed me. Fixed shortly. (In reply to comment #4) > fixed in r57871. Thanks for the fix. I saw another error when I ran the test without chromium's tree. ====================================================================== FAIL: test_basics (webkitpy.layout_tests.run_webkit_tests_unittest.DryrunTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py", line 67, in test_basics 'fast/html'])) File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py", line 41, in passing_run res = run_webkit_tests.main(options, args, False) File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 1560, in main port_obj.setup_test_run() File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py", line 163, in setup_test_run dump_render_tree_binary_path = self._path_to_driver() File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 151, in _path_to_driver 'Contents', 'MacOS', self.driver_name()) File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 99, in _build_path return self.path_from_chromium_base('xcodebuild', *comps) File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py", line 144, in path_from_chromium_base abspath) AssertionError: could not find Chromium base dir from /Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.pyc ---------------------------------------------------------------------- Ran 379 tests in 2.484s FAILED (failures=1) makes sense. I hadn't tested that possibility. I'll comment those tests out for now. Committed r57872: <http://trac.webkit.org/changeset/57872> By the way, have any of you noticed that the output of test-webkitpy "flickers" during one of the unit tests -- starting perhaps less than a week ago? It doesn't seem like that should need to happen. It may be a sign that a better test mechanism can be used. I think I found that the issue occurs at least during the following test: test-webkitpy webkitpy.layout_tests.run_webkit_tests_unittest.MainTest (In reply to comment #8) > By the way, have any of you noticed that the output of test-webkitpy "flickers" > during one of the unit tests -- starting perhaps less than a week ago? > > It doesn't seem like that should need to happen. It may be a sign that a > better test mechanism can be used. I think I found that the issue occurs at > least during the following test: > > test-webkitpy webkitpy.layout_tests.run_webkit_tests_unittest.MainTest At least some of the flickering occurs during running run_webkit_tests_unittest.py and is the result of not disabling the progress bar properly, I think. I'll look into that today while getting the remaining logging cleaned up. |