Bug 37838

Summary:

new-run-webkit-tests: add a --no-retry-failures flag

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, eric, ojan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

Dirk Pranke

Reported 2010-04-19 18:40:26 PDT

We should add a --no-retry-failures flag in case we want to check something but don't want to retry things.

Attachments
Patch (5.13 KB, patch) 2010-04-19 18:41 PDT, Dirk Pranke	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2010-04-19 18:41:58 PDT

Created attachment 53760 [details] Patch

Eric Seidel (no email)

Comment 2 2010-04-19 18:46:44 PDT

Comment on attachment 53760 [details] Patch Why do we want more options? I'm trying to cut down on the number of options the user sees so we can make --help less intimidating. These seem unlikely for a user to use.

Dirk Pranke

Comment 3 2010-04-19 18:49:28 PDT

(In reply to comment #2) > (From update of attachment 53760 [details]) > Why do we want more options? I'm trying to cut down on the number of options > the user sees so we can make --help less intimidating. These seem unlikely for > a user to use. Certainly --retry-failures is unlikely to be used, since it's the default. I would be fine if --no-retry-failures was hidden, but I'd like for it to be there, especially to help w/ unit testing coverage.

Adam Barth

Comment 4 2010-04-22 12:54:36 PDT

Comment on attachment 53760 [details] Patch WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:1768 + optparse.make_option("--no-retry-failures", action="store_false", I thought we had magic to generate the [no-] versions.

Eric Seidel (no email)

Comment 5 2010-04-22 13:00:29 PDT

I've not written the --no- magic yet.

Dirk Pranke

Comment 6 2010-04-23 12:43:25 PDT

Committed r58183: <http://trac.webkit.org/changeset/58183>

WebKit Review Bot

Comment 7 2010-04-23 13:03:04 PDT

http://trac.webkit.org/changeset/58183 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.