new-run-webkit-tests: add a --no-retry-failures flag

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dirk Pranke]

We should add a --no-retry-failures flag in case we want to check something but don't want to retry things.

[Dirk Pranke]

Created attachment 53760 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 53760 [details]
Patch

Why do we want more options?  I'm trying to cut down on the number of options the user sees so we can make --help less intimidating.  These seem unlikely for a user to use.

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 53760 [details])
> Why do we want more options?  I'm trying to cut down on the number of options
> the user sees so we can make --help less intimidating.  These seem unlikely for
> a user to use.

Certainly --retry-failures is unlikely to be used, since it's the default.

I would be fine if --no-retry-failures was hidden, but I'd like for it to be there, especially to help w/ unit testing coverage.

[Adam Barth]

Comment on attachment 53760 [details]
Patch

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:1768
 +          optparse.make_option("--no-retry-failures", action="store_false",
I thought we had magic to generate the [no-] versions.

[Eric Seidel (no email)]

I've not written the --no- magic yet.

[Dirk Pranke]

Committed r58183: <http://trac.webkit.org/changeset/58183>

[WebKit Review Bot]

http://trac.webkit.org/changeset/58183 might have broken Qt Linux Release