| Summary: | Wrong header being included in FontPlatformDataCairo.cpp | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Luís Felipe Strano Moraes <lfelipe> | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Minor | CC: | commit-queue, lfelipe | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 53812 [details]
Include just gdk instead of gtk for FontPlatformDataCairo.cpp
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp just use GDK to discover if there are X settings on some screen to adjust its parameters. So no need to include gtk.h there.
Comment on attachment 53812 [details]
Include just gdk instead of gtk for FontPlatformDataCairo.cpp
r=me
Comment on attachment 53812 [details] Include just gdk instead of gtk for FontPlatformDataCairo.cpp Clearing flags on attachment: 53812 Committed r57984: <http://trac.webkit.org/changeset/57984> All reviewed patches have been landed. Closing bug. |
Created attachment 53733 [details] Proposed patch The file WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp includes the gtk header when in fact it only uses gdk. A simple s/gtk/gdk/ fixes it (attached).