Bug 37817

Summary:

new-run-webkit-tests no longer runs on chromium canaries

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Dirk Pranke

Reported 2010-04-19 13:14:25 PDT

See http://trac.webkit.org/changeset/57806 , which broke the canaries.

Attachments
Patch (1.99 KB, patch) 2010-04-19 13:16 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2010-04-19 13:16:58 PDT

Created attachment 53710 [details] Patch

Dirk Pranke

Comment 2 2010-04-19 13:17:42 PDT

Committed r57831: <http://trac.webkit.org/changeset/57831>

Eric Seidel (no email)

Comment 3 2010-04-19 13:18:15 PDT

Comment on attachment 53710 [details] Patch That looks like it would cause very confusing behavior for --use-drt. Seems we should exit(1) in that case, or at least log.

Eric Seidel (no email)

Comment 4 2010-04-19 13:19:13 PDT

Comment on attachment 53710 [details] Patch Did you mean to upload this with --no-review? I still think this needs a log message to be less confusing. :)

Dirk Pranke

Comment 5 2010-04-19 13:26:01 PDT

(In reply to comment #3) > (From update of attachment 53710 [details]) > That looks like it would cause very confusing behavior for --use-drt. Seems we > should exit(1) in that case, or at least log. You're right. I'll add that.

Dirk Pranke

Comment 6 2010-04-19 13:26:27 PDT

(In reply to comment #4) > (From update of attachment 53710 [details]) > Did you mean to upload this with --no-review? There's a --no-review? I didn't know about that. I'll do that next time. -- Dirk

Eric Seidel (no email)

Comment 7 2010-04-19 13:34:03 PDT

webkit-patch help upload can show you what flags it has. --request-commit and --no-review are the most common ones I use.

Kent Tamura

Comment 8 2010-04-19 15:18:23 PDT

(In reply to comment #0) > See http://trac.webkit.org/changeset/57806 , which broke the canaries. I'm sorry for that! I didn't expect "import" made a problem.

WebKit Review Bot

Comment 9 2010-04-19 16:07:31 PDT

http://trac.webkit.org/changeset/57831 might have broken Windows Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/57829 http://trac.webkit.org/changeset/57830 http://trac.webkit.org/changeset/57831 http://trac.webkit.org/changeset/57832 http://trac.webkit.org/changeset/57833 http://trac.webkit.org/changeset/57834 http://trac.webkit.org/changeset/57835

Note You need to log in before you can comment on or make changes to this bug.