| Summary: | new-run-webkit-tests no longer runs on chromium canaries | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2010-04-19 13:14:25 PDT
Created attachment 53710 [details]
Patch
Committed r57831: <http://trac.webkit.org/changeset/57831> Comment on attachment 53710 [details]
Patch
That looks like it would cause very confusing behavior for --use-drt. Seems we should exit(1) in that case, or at least log.
Comment on attachment 53710 [details]
Patch
Did you mean to upload this with --no-review?
I still think this needs a log message to be less confusing. :)
(In reply to comment #3) > (From update of attachment 53710 [details]) > That looks like it would cause very confusing behavior for --use-drt. Seems we > should exit(1) in that case, or at least log. You're right. I'll add that. (In reply to comment #4) > (From update of attachment 53710 [details]) > Did you mean to upload this with --no-review? There's a --no-review? I didn't know about that. I'll do that next time. -- Dirk webkit-patch help upload can show you what flags it has. --request-commit and --no-review are the most common ones I use. (In reply to comment #0) > See http://trac.webkit.org/changeset/57806 , which broke the canaries. I'm sorry for that! I didn't expect "import" made a problem. http://trac.webkit.org/changeset/57831 might have broken Windows Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/57829 http://trac.webkit.org/changeset/57830 http://trac.webkit.org/changeset/57831 http://trac.webkit.org/changeset/57832 http://trac.webkit.org/changeset/57833 http://trac.webkit.org/changeset/57834 http://trac.webkit.org/changeset/57835 |