Bug 37817 - new-run-webkit-tests no longer runs on chromium canaries
Summary: new-run-webkit-tests no longer runs on chromium canaries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-19 13:14 PDT by Dirk Pranke
Modified: 2010-04-19 16:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2010-04-19 13:16 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-04-19 13:14:25 PDT 
See http://trac.webkit.org/changeset/57806 , which broke the canaries.
Comment 1 Dirk Pranke 2010-04-19 13:16:58 PDT 
Created attachment 53710 [details]
Patch
Comment 2 Dirk Pranke 2010-04-19 13:17:42 PDT 
Committed r57831: <http://trac.webkit.org/changeset/57831>
Comment 3 Eric Seidel (no email) 2010-04-19 13:18:15 PDT 
Comment on attachment 53710 [details]
Patch

That looks like it would cause very confusing behavior for --use-drt.  Seems we should exit(1) in that case, or at least log.
Comment 4 Eric Seidel (no email) 2010-04-19 13:19:13 PDT 
Comment on attachment 53710 [details]
Patch

Did you mean to upload this with --no-review?

I still think this needs a log message to be less confusing. :)
Comment 5 Dirk Pranke 2010-04-19 13:26:01 PDT 
(In reply to comment #3)
> (From update of attachment 53710 [details])
> That looks like it would cause very confusing behavior for --use-drt.  Seems we
> should exit(1) in that case, or at least log.

You're right. I'll add that.
Comment 6 Dirk Pranke 2010-04-19 13:26:27 PDT 
(In reply to comment #4)
> (From update of attachment 53710 [details])
> Did you mean to upload this with --no-review?

There's a --no-review? I didn't know about that. I'll do that next time.

-- Dirk
Comment 7 Eric Seidel (no email) 2010-04-19 13:34:03 PDT 
webkit-patch help upload

can show you what flags it has.  --request-commit and --no-review are the most common ones I use.
Comment 8 Kent Tamura 2010-04-19 15:18:23 PDT 
(In reply to comment #0)
> See http://trac.webkit.org/changeset/57806 , which broke the canaries.

I'm sorry for that!
I didn't expect "import" made a problem.