Bug 37780

Summary:

new-run-webkit-tests: some messages need to be preserved in --verbose mode

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, eric, mjs, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

37643

Attachments:

Description	Flags
Patch	none

Description Dirk Pranke 2010-04-18 16:04:22 PDT

A bunch of messages are currently disabled in --verbose mode; this means we lose profiling information. We should log all messages except for the ones that are truly incremental progress-style updates.

Comment 1 Dirk Pranke 2010-04-18 16:09:38 PDT

Created attachment 53641 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-04-19 00:10:57 PDT

Comment on attachment 53641 [details]
Patch

OK.

Comment 3 Ojan Vafai 2010-04-19 08:26:13 PDT

This patch is fine. I think we should try to move in the direction of --verbose just implying --log all or something like that.

Comment 4 Dirk Pranke 2010-04-19 10:42:29 PDT

(In reply to comment #3)
> This patch is fine. I think we should try to move in the direction of --verbose
> just implying --log all or something like that.

It more or less does, except it turns off the progress bars.

Comment 5 Dirk Pranke 2010-04-19 14:41:14 PDT

Comment on attachment 53641 [details]
Patch

Clearing flags on attachment: 53641

Committed r57841: <http://trac.webkit.org/changeset/57841>

Comment 6 Dirk Pranke 2010-04-19 14:41:19 PDT

All reviewed patches have been landed.  Closing bug.