Bug 37780

Summary: new-run-webkit-tests: some messages need to be preserved in --verbose mode
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, eric, mjs, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 37643    
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2010-04-18 16:04:22 PDT
A bunch of messages are currently disabled in --verbose mode; this means we lose profiling information. We should log all messages except for the ones that are truly incremental progress-style updates.
Attachments
Patch (5.39 KB, patch)
2010-04-18 16:09 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-04-18 16:09:38 PDT
Created attachment 53641 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-19 00:10:57 PDT
Comment on attachment 53641 [details] Patch OK.
Ojan Vafai
Comment 3 2010-04-19 08:26:13 PDT
This patch is fine. I think we should try to move in the direction of --verbose just implying --log all or something like that.
Dirk Pranke
Comment 4 2010-04-19 10:42:29 PDT
(In reply to comment #3) > This patch is fine. I think we should try to move in the direction of --verbose > just implying --log all or something like that. It more or less does, except it turns off the progress bars.
Dirk Pranke
Comment 5 2010-04-19 14:41:14 PDT
Comment on attachment 53641 [details] Patch Clearing flags on attachment: 53641 Committed r57841: <http://trac.webkit.org/changeset/57841>
Dirk Pranke
Comment 6 2010-04-19 14:41:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.