Bug 37757

Summary: Refactor SheriffIRCBot to use a CommandCenter
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: cjerdonek, dbates, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 37710    
Attachments:
Description Flags
Patch eric: review-

Adam Barth
Reported 2010-04-17 14:52:24 PDT
Refactor SheriffIRCBot to use a CommandCenter
Attachments
Patch (37.11 KB, patch)
2010-04-17 14:55 PDT, Adam Barth 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-17 14:55:06 PDT
Created attachment 53611 [details] Patch
WebKit Review Bot
Comment 2 2010-04-17 14:58:47 PDT
Attachment 53611 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WARNING: Skipping non-existent file: WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot.py WebKitTools/Scripts/webkitpy/tool/bot/irc/irccommands.py:39: deprecated form of raising exception [pep8/W602] [5] WARNING: Skipping non-existent file: WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py WARNING: Skipping non-existent file: WebKitTools/Scripts/webkitpy/tool/bot/irc_command.py Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2010-04-18 23:40:46 PDT
Comment on attachment 53611 [details] Patch I can't tell what's moving files and what is actual changes. :( Your ChangeLog doesn't really help me tell either.
Eric Seidel (no email)
Comment 4 2010-04-18 23:41:32 PDT
This change would be better split in two. I think it's possibly reviewable as-is, but it would need a better ChangeLog.
Eric Seidel (no email)
Comment 5 2010-04-19 13:22:25 PDT
Comment on attachment 53611 [details] Patch r- per the above comment. I can't really tell what's going on here.
Note You need to log in before you can comment on or make changes to this bug.