Bug 37735

Summary: Remove JSC specific code from WebCore::AtomicString
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: PlatformAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2010-04-16 16:52:47 PDT
Add generic constructor/add/find methods that take a UChar* & length, along with a known existing hash for the string. This removes the remaining JSC specific code from platform/text.
Attachments
The patch (43.32 KB, patch)
2010-04-16 16:54 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-04-16 16:54:33 PDT
Created attachment 53582 [details] The patch
WebKit Review Bot
Comment 2 2010-04-16 17:00:12 PDT
Attachment 53582 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/text/AtomicString.cpp:194: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/text/AtomicString.cpp:243: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-04-16 17:01:23 PDT
Comment on attachment 53582 [details] The patch r=me!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
WebKit Review Bot
Comment 4 2010-04-16 17:20:41 PDT
http://trac.webkit.org/changeset/57766 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release
Eric Seidel (no email)
Comment 5 2010-04-16 17:23:50 PDT
It appears this broke a bunch of bots. Wasn't up for review long enough for the EWSes to catch it.
Gavin Barraclough
Comment 6 2010-04-16 20:26:36 PDT
Landed in r57766.
Note You need to log in before you can comment on or make changes to this bug.