Bug 37728

Summary: Setting media element 'src' attribute should trigger load immediately
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jer.noble, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Eric Carlson
Reported 2010-04-16 13:48:18 PDT
The HTML5 spec used to require a script to call load() after changing the 'src' attribute, but it now says the change should be immediate. From section 4.8.9.2: If a src attribute of a media element is set or changed, the user agent must invoke the media element's media element load algorithm. (Removing the src attribute does not do this, even if there are source elements present.)
Attachments
proposed patch (18.72 KB, patch)
2010-04-16 14:51 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-04-16 14:51:17 PDT
Created attachment 53567 [details] proposed patch
Eric Carlson
Comment 2 2010-04-19 11:30:30 PDT
<rdar://problem/7879963>
Eric Carlson
Comment 3 2010-04-19 11:31:52 PDT
http://trac.webkit.org/changeset/57820
Eric Seidel (no email)
Comment 4 2010-04-19 11:55:43 PDT
Looks like this broke Tiger? http://build.webkit.org/results/Tiger%20Intel%20Release/r57821%20(10961)/media/video-source-error-diffs.txt
WebKit Review Bot
Comment 5 2010-04-19 12:12:00 PDT
http://trac.webkit.org/changeset/57820 might have broken Leopard Intel Release (Tests)
Eric Seidel (no email)
Comment 6 2010-04-19 13:07:13 PDT
Actually, looks like this broke all versions of Mac besides Snow Leopard. :(
Eric Carlson
Comment 7 2010-04-19 13:14:55 PDT
http://trac.webkit.org/changeset/57830 should fix the regression.
Note You need to log in before you can comment on or make changes to this bug.