Bug 37716

Summary: WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile with minimal cofigured Qt
Product: WebKit Reporter: Chang Shu <cshu>
Component: WebKit QtAssignee: Chang Shu <cshu>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: laszlo.gombos
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Attachments:
Description Flags
fix patch laszlo.gombos: review-

Description Chang Shu 2010-04-16 11:12:20 PDT 
NotificationPresenterClientQt.h refers QSystemTrayIcon in qsystemtrayicon.h.
But QSystemTrayIcon is not declared with QT_NO_SYSTEMTRAYICON defined, which is true in minimal and small config of Qt.
Comment 1 Chang Shu 2010-04-16 11:26:24 PDT 
Created attachment 53544 [details]
fix patch
Comment 2 Laszlo Gombos 2010-04-18 21:32:59 PDT 
Comment on attachment 53544 [details]
fix patch

This patch would be more future-proof and would work in more build setups if test would check if QT_NO_SYSTEMTRAYICON is defined.

I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.
Comment 3 Laszlo Gombos 2010-04-18 21:33:39 PDT 

*** This bug has been marked as a duplicate of bug 37442 ***
Comment 4 Chang Shu 2010-04-19 06:40:26 PDT 
(In reply to comment #2)
> (From update of attachment 53544 [details])
> This patch would be more future-proof and would work in more build setups if
> test would check if QT_NO_SYSTEMTRAYICON is defined.
> 
> I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.

I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is defined.