Bug 37665

Summary:

[Qt] Rename QtLauncher to QtTestBrowser

Product:

WebKit

Reporter:

Simon Hausmann <hausmann>

Component:

New Bugs

Assignee:

Simon Hausmann <hausmann>

Status:

CLOSED FIXED

Severity:

Normal

CC:

commit-queue, jesus, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

35784

Attachments:

Description	Flags
Patch	none
Rename	koivisto: review+, commit-queue: commit-queue-

Description Simon Hausmann 2010-04-15 11:24:35 PDT

[Qt] Rename QtLauncher to QtTestBrowser

Comment 1 Simon Hausmann 2010-04-15 11:27:44 PDT

Created attachment 53455 [details]
Patch

Comment 2 Simon Hausmann 2010-04-15 12:05:17 PDT

Created attachment 53461 [details]
Rename

Comment 3 WebKit Review Bot 2010-04-15 12:11:06 PDT

Attachment 53461 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
6:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webpage.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/mainwindow.h
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/mainwindow.cpp
WebKitTools/QtTestBrowser/webinspector.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/useragentlist.txt
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/urlloader.h
WebKitTools/QtTestBrowser/webpage.cpp:33:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/webpage.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/urlloader.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/locationedit.cpp
WebKitTools/QtTestBrowser/main.cpp:33:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/main.cpp:67:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/QtTestBrowser/locationedit.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/mainwindow.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webview.h
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/utils.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webview.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/locationedit.h
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/QtLauncher.pro
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/QtLauncher.qrc
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/utils.h
WebKitTools/QtTestBrowser/utils.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/main.cpp
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webinspector.h
WebKitTools/QtTestBrowser/urlloader.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/QtTestBrowser/urlloader.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Skipping non-existent file: WebKitTools/QtLauncher/webpage.h
WebKitTools/QtTestBrowser/webview.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/QtTestBrowser/webview.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 15 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Antti Koivisto 2010-04-19 18:13:58 PDT

Comment on attachment 53461 [details]
Rename

rs=me

Comment 5 WebKit Commit Bot 2010-04-21 04:49:40 PDT

Comment on attachment 53461 [details]
Rename

Rejecting patch 53461 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Antti Koivisto', '--force']" exit_code: 1
Last 500 characters of output:
Tools/QtLauncher/webview.cpp
rm 'WebKitTools/QtLauncher/webview.cpp'
patching file WebKitTools/QtLauncher/webview.h
rm 'WebKitTools/QtLauncher/webview.h'
patching file WebKitTools/QtTestBrowser/QtTestBrowser.pro
patching file WebKitTools/QtTestBrowser/main.cpp
Hunk #1 succeeded at 1050 (offset 1 line).
Hunk #2 succeeded at 1069 (offset 1 line).
patching file WebKitTools/QtTestBrowser/useragentlist.txt
patching file WebKitTools/Scripts/run-launcher
patching file WebKitTools/Scripts/webkitdirs.pm

Full output: http://webkit-commit-queue.appspot.com/results/1792019

Comment 6 Simon Hausmann 2010-05-14 08:25:41 PDT

Committed r59474: <http://trac.webkit.org/changeset/59474>

Comment 7 Simon Hausmann 2010-05-14 08:35:31 PDT

Revision r59474 cherry-picked into qtwebkit-2.0 with commit 41b8115b256ed43acdf1976447925d5c1c6071a7

Comment 8 Simon Hausmann 2010-05-15 13:30:10 PDT

Committed r59552: <http://trac.webkit.org/changeset/59552>