Bug 37660

Summary:

LayoutTest breakage in V8 bindings after r57627

Product:

WebKit

Reporter:

Justin Schuh <jschuh>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ajwong, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	dglazkov: review+

Description Justin Schuh 2010-04-15 10:03:25 PDT

There's an error in V8NamedNodeMap::setNamedItemNSCallback() and V8NamedNodeMap::setNamedItemCallback() that's causing failures in the following tests after r57627:

hc_namednodemapinuseattributeerr.html
hc_namednodemapsetnameditemreturnvalue.html
hc_namednodemapwrongdocumenterr.html
hc_namednodemapinvalidtype1.html
NamedNodeMap-setNamedItem-crash.html

Comment 1 Justin Schuh 2010-04-15 10:25:28 PDT

Created attachment 53448 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2010-04-15 10:26:40 PDT

Comment on attachment 53448 [details]
Patch

ok.

Comment 3 Albert J. Wong 2010-04-15 11:24:54 PDT

Landed as r57658

Closing.

Comment 4 Darin Adler 2014-04-24 16:45:17 PDT

Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.