Bug 37660

Summary: LayoutTest breakage in V8 bindings after r57627
Product: WebKit Reporter: Justin Schuh <jschuh>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ajwong, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch dglazkov: review+

Justin Schuh
Reported 2010-04-15 10:03:25 PDT
There's an error in V8NamedNodeMap::setNamedItemNSCallback() and V8NamedNodeMap::setNamedItemCallback() that's causing failures in the following tests after r57627: hc_namednodemapinuseattributeerr.html hc_namednodemapsetnameditemreturnvalue.html hc_namednodemapwrongdocumenterr.html hc_namednodemapinvalidtype1.html NamedNodeMap-setNamedItem-crash.html
Attachments
Patch (1.77 KB, patch)
2010-04-15 10:25 PDT, Justin Schuh 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Schuh
Comment 1 2010-04-15 10:25:28 PDT
Created attachment 53448 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-04-15 10:26:40 PDT
Comment on attachment 53448 [details] Patch ok.
Albert J. Wong
Comment 3 2010-04-15 11:24:54 PDT
Landed as r57658 Closing.
Darin Adler
Comment 4 2014-04-24 16:45:17 PDT
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.
Note You need to log in before you can comment on or make changes to this bug.