Summary: | new-run-webkit-tests should not assume the test driver is called "DumpRenderTree" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, eric, ojan, pam, tony, victorw, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dirk Pranke
2010-04-14 19:20:35 PDT
1) We can change the UI if you like. 2) We have a team killing test_shell and replacing it with DumpRenderTree for the Chromium port, so this problem will solve itself naturally. (In reply to comment #1) > 1) We can change the UI if you like. > Yeah, I'm about to submit a patch to do so :) > 2) We have a team killing test_shell and replacing it with DumpRenderTree for > the Chromium port, so this problem will solve itself naturally. Yes, I know. I look forward to it, but would like to avoid confusion (not the least of which is my own) in the meantime. FWIW, I'm in support of just calling in DumpRenderTree (or DRT). Chromium devs can learn to adapt. Maybe we should have a gyp step that copies test_shell to DumpRenderTree :) As long as DumpRenderTree has the ability to generate text-only diffs (which are prefered) and pixel dumps (which are sometimes necessary), I continue to think its name should be changed :) Created attachment 53401 [details]
Patch
Comment on attachment 53401 [details]
Patch
ok.
Comment on attachment 53401 [details] Patch Clearing flags on attachment: 53401 Committed r57672: <http://trac.webkit.org/changeset/57672> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/57672 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/57672 http://trac.webkit.org/changeset/57673 http://trac.webkit.org/changeset/57674 http://trac.webkit.org/changeset/57675 http://trac.webkit.org/changeset/57676 |