Bug 37371 - new-run-webkit-tests should talk about DumpRenderTree not test_shell
Summary: new-run-webkit-tests should talk about DumpRenderTree not test_shell
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-09 15:52 PDT by Adam Barth
Modified: 2010-04-14 20:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (59.17 KB, patch)
2010-04-09 15:54 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
ignore - wrong bug. (5.42 KB, patch)
2010-04-14 20:01 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-09 15:52:14 PDT
new-run-webkit-tests should talk about DumpRenderTree not test_shell
Comment 1 Adam Barth 2010-04-09 15:54:42 PDT
Created attachment 53007 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-09 16:13:10 PDT
Comment on attachment 53007 [details]
Patch

Darin Adler has long talked of renaming drt to something better describing what it does. But you're right. Test_shell is Greek to webkitters. Rs=me if all you're doing is renaming.
Comment 3 Adam Barth 2010-04-09 16:19:49 PDT
Comment on attachment 53007 [details]
Patch

Clearing flags on attachment: 53007

Committed r57381: <http://trac.webkit.org/changeset/57381>
Comment 4 Adam Barth 2010-04-09 16:19:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Dirk Pranke 2010-04-14 20:01:34 PDT
Created attachment 53400 [details]
ignore - wrong bug.
Comment 6 Dirk Pranke 2010-04-14 20:02:39 PDT
Comment on attachment 53400 [details]
ignore - wrong bug.

whoops - wrong bug.