Bug 37595

Summary: Implement layoutTestController's addUserStyleSheet and setAuthorAndUserStylesEnabled on Chromium port
Product: WebKit Reporter: Matt Perry <mpcomplete>
Component: WebKit APIAssignee: Matt Perry <mpcomplete>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
Attachments:
Description Flags
simple patch that adds the given methods to the WebKit API
none
fix style issues none

Matt Perry
Reported 2010-04-14 12:29:42 PDT
In order to fix a couple failing layout tests, we need to implement some missing methods for the Chromium port.
Attachments
simple patch that adds the given methods to the WebKit API (4.59 KB, patch)
2010-04-14 12:34 PDT, Matt Perry 		no flags
DetailsFormatted DiffDiff
fix style issues (4.60 KB, patch)
2010-04-14 12:44 PDT, Matt Perry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Perry
Comment 1 2010-04-14 12:34:37 PDT
Created attachment 53351 [details] simple patch that adds the given methods to the WebKit API
WebKit Review Bot
Comment 2 2010-04-14 12:36:27 PDT
Attachment 53351 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:1889: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKit/chromium/src/WebSettingsImpl.cpp:188: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Matt Perry
Comment 3 2010-04-14 12:44:58 PDT
Created attachment 53354 [details] fix style issues
Dirk Pranke
Comment 4 2010-04-15 12:38:09 PDT
drive-by LGTM (but I'm not a reviewer).
Dimitri Glazkov (Google)
Comment 5 2010-04-15 13:58:39 PDT
Comment on attachment 53354 [details] fix style issues ok.
WebKit Commit Bot
Comment 6 2010-04-15 18:00:37 PDT
Comment on attachment 53354 [details] fix style issues Clearing flags on attachment: 53354 Committed r57699: <http://trac.webkit.org/changeset/57699>
WebKit Commit Bot
Comment 7 2010-04-15 18:00:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.