Summary: | Implement layoutTestController's addUserStyleSheet and setAuthorAndUserStylesEnabled on Chromium port | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Perry <mpcomplete> | ||||||
Component: | WebKit API | Assignee: | Matt Perry <mpcomplete> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dpranke, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows Vista | ||||||||
Attachments: |
|
Description
Matt Perry
2010-04-14 12:29:42 PDT
Created attachment 53351 [details]
simple patch that adds the given methods to the WebKit API
Attachment 53351 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:1889: Place brace on its own line for function definitions. [whitespace/braces] [4]
WebKit/chromium/src/WebSettingsImpl.cpp:188: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53354 [details]
fix style issues
drive-by LGTM (but I'm not a reviewer). Comment on attachment 53354 [details]
fix style issues
ok.
Comment on attachment 53354 [details] fix style issues Clearing flags on attachment: 53354 Committed r57699: <http://trac.webkit.org/changeset/57699> All reviewed patches have been landed. Closing bug. |