Bug 37586

Summary:

fix new-run-webkit-tests to fit in 80 columns

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, eric, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none

Description Dirk Pranke 2010-04-14 11:03:31 PDT

For full PEP-8 compliance all of our Python code should fit in 80 columns (see bug 37477).

Comment 1 Eric Seidel (no email) 2010-04-14 11:41:23 PDT

I don't think we want this.  The rest of WebKit code doesn't wrap to 80 columns.  I don't think complying with pep8/E501 really buys us anything except confusion.

Comment 2 Dirk Pranke 2010-04-14 16:50:52 PDT

Created attachment 53384 [details]
patch

Comment 3 Adam Barth 2010-04-14 21:00:34 PDT

Comment on attachment 53384 [details]
patch

At the risk of getting yelled at by Eric, I'm r+ing this change.  In general, I think the 80c is the least important of the style rules, but what can you do?

Comment 4 Dirk Pranke 2010-04-15 14:02:09 PDT

Comment on attachment 53384 [details]
patch

Clearing flags on attachment: 53384

Committed r57673: <http://trac.webkit.org/changeset/57673>

Comment 5 Dirk Pranke 2010-04-15 14:02:15 PDT

All reviewed patches have been landed.  Closing bug.