| Summary: | Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Alexander Pavlov (apavlov)
2010-04-14 09:41:38 PDT
Created attachment 53340 [details]
[PATCH] Suggested solution
Looks good! I just noticed this was missing the other day, glad to see you add it =) [Collision: I agree with Tim's r+] > + var nextIndex = foundIndex + (reverse ? -1 : 1); I haven't seen a case where we use (null + #) but this works fine in JavaScript and the code is pretty clean here. > + this.complete(false, event.shiftKey); Is just event.shiftKey enough? Do you feel that we should say something stronger like this: event.shiftKey && !event.ctrlKey && !event.metaKey TextMate for example allows Shift+Esc to go back through a list but not Shift+Ctrl+Esc or Shift+Alt+Esc. Apparently Safari / OS X captures these combinations and handles other actions, but it could be possible that other platforms would let such a combination through. Either way, I think this is unlikely to occur, but something to think about. Comment on attachment 53340 [details] [PATCH] Suggested solution Clearing flags on attachment: 53340 Committed r57592: <http://trac.webkit.org/changeset/57592> All reviewed patches have been landed. Closing bug. |