Summary: | Adjust Chromium's bindings to recent changes in WebKit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | anton muhin <antonm> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | levin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
anton muhin
2010-04-14 08:42:12 PDT
After http://trac.webkit.org/changeset/57535/ Chromium's canary bots started to fail for the following tests: http/tests/xmlhttprequest/origin-whitelisting-all.html http/tests/xmlhttprequest/origin-whitelisting-exact-match.html http/tests/xmlhttprequest/origin-whitelisting-https.html http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with- subdomains.html http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html http/tests/xmlhttprequest/origin-whitelisting-subdomains.html http/tests/security/local-image-from-remote-whitelisted.html http/tests/xmlhttprequest/origin-whitelisting-removal.html Two of those are new. It looks like we need to expose into the bindings new API, see sample failure: --- platform/chromium-win/http/tests/security/local-image-from-remote-whitelisted-expected.txt (revision 0) +++ platform/chromium-win/http/tests/security/local-image-from-remote-whitelisted-expected.txt (revision 0) @@ -0,0 +1,4 @@ +CONSOLE MESSAGE: line 8: Uncaught TypeError: Object [object Object] has no method 'addOriginAccessWhitelistEntry' +This test is to see if a remote file can include a local image when the access has been white listed using addOriginAccessWhitelistEntry. + +Test has not run. Planning to skip the tests for now until proper solution is done. Created attachment 53333 [details]
Plain rebaseling + skipping timing out tests
Comment on attachment 53333 [details]
Plain rebaseling + skipping timing out tests
Pleas fix the TABs in the ChangeLog.
Also, it looks like the two baselines you are adding are actually failures.
Please consider filing a bug to implement "addOriginAccessWhitelistEntry" and perhaps those tests should be listed as failures in test_expectations instead of having new baselines.
Created attachment 53334 [details]
Next iteration
Submitting right now.
Created attachment 53335 [details]
Correct next iteration
Sorry, wrong diff
(In reply to comment #3) > (From update of attachment 53333 [details]) > Pleas fix the TABs in the ChangeLog. > > Also, it looks like the two baselines you are adding are actually failures. > > Please consider filing a bug to implement "addOriginAccessWhitelistEntry" and > perhaps those tests should be listed as failures in test_expectations instead > of having new baselines. David, as per your suggestion I've filed https://bugs.webkit.org/show_bug.cgi?id=37578 https://bugs.webkit.org/attachment.cgi?id=53335 was landed as http://trac.webkit.org/changeset/57582 Closing the bug. |