Bug 37568

Summary: SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, krit, webkit.review.bot, xan.lopez
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch krit: review+

Nikolas Zimmermann
Reported 2010-04-14 02:03:25 PDT
SVGRenderStyle(Defs) is old legacy code and needs to be cleaned up. While I'm at it, we could save memory be joining StyleMaskData/StyleClipData in a single StyleResourceData. For consistency StyleMarkerData will be named StyleInheritedResourceData. All naming schemes should be unified for clipper / masker / marker / filter, see the upcoming patch.
Attachments
Patch (46.98 KB, patch)
2010-04-14 02:12 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch (49.26 KB, patch)
2010-04-14 03:14 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-04-14 02:12:50 PDT
Created attachment 53323 [details] Patch
WebKit Review Bot
Comment 2 2010-04-14 02:54:48 PDT
Attachment 53323 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1602462
WebKit Review Bot
Comment 3 2010-04-14 03:13:25 PDT
Attachment 53323 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1671314
Nikolas Zimmermann
Comment 4 2010-04-14 03:14:21 PDT
Created attachment 53325 [details] Patch
Nikolas Zimmermann
Comment 5 2010-04-14 03:15:50 PDT
Updated patch against trunk, was missing RenderSVGResourceClipper changes after Dirks commit.
Dirk Schulze
Comment 6 2010-04-14 03:40:14 PDT
Comment on attachment 53325 [details] Patch LGTM r=me
Nikolas Zimmermann
Comment 7 2010-04-14 03:44:52 PDT
Committed r57575: <http://trac.webkit.org/changeset/57575>
Note You need to log in before you can comment on or make changes to this bug.