Bug 37531 – Dummy bug for testing code review tool.

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Julie Parent]

This is just a test bug for testing reitveld integration.
Don't worry, I am only making one fake bug.

[Julie Parent]

Created attachment 53298 [details]
Dummy patch.

[Julie Parent]

Comment on attachment 53298 [details]
Dummy patch.

testing

[Julie Parent]

Comment on attachment 53298 [details]
Dummy patch.

> 
> 
> 
> 
> setTimeout(function() {
> var codeViewFrame = document.getElementsByTagName('frame')[0];
> var reviewFrame = document.getElementsByTagName('frame')[1];
> var reviewDoc = reviewFrame.contentDocument;
> 
> // Add button for showing Reitveld.
> var prettyPatchButton = reviewDoc.getElementById('viewPrettyPatchButton');
> var awesomeButton = reviewDoc.createElement('input');
> awesomeButton.type = 'button';
> awesomeButton.id = 'reitveldBtn';
> awesomeButton.value = 'View in Reitveld';
> awesomeButton.onclick = navToReitveld;
> prettyPatchButton.parentNode.appendChild(awesomeButton);
> 
> function navToReitveld() {
>   // TODO: Get real URL here.
>   codeViewFrame.location = 'http://wkrietveld.appspot.com/';
> }
> 
> function updateComments() {
>   // Hook into submit action, get data from reitveld.
>   var commentField = reviewDoc.getElementById('comment');
> 	var comments = 
>   commentField.value = comments;
> }
> 
> }, 1000);

[Julie Parent]

Comment on attachment 53298 [details]
Dummy patch.

[e-mail]

[Julie Parent]

Comment on attachment 53298 [details]
Dummy patch.

http://wkrietveld.appspot.com/2001/diff/1/2
File templates/patch.html (right):

http://wkrietveld.appspot.com/2001/diff/1/2#newcode162
templates/patch.html:162: console.log("Publishing codereview comments failed with real uplod!")
THIS IS NEW!

On 2010/04/15 20:52:36, contributor wrote:
> On 2010/04/15 20:50:48, contributor wrote:
> > On 2010/04/15 20:41:55, contributor wrote:
> > > This line is too long.
> > 
> > Done.
> 
> Done.

[Julie Parent]

Comment on attachment 53298 [details]
Dummy patch.

http://wkrietveld.appspot.com/2001/diff/1/2
File templates/patch.html (right):

http://wkrietveld.appspot.com/2001/diff/1/2#newcode162
templates/patch.html:162: console.log("Publishing codereview comments failed with real uplod!")
This is awesome!

On 2010/04/15 20:57:21, contributor wrote:
> THIS IS NEW!
> 
> On 2010/04/15 20:52:36, contributor wrote:
> > On 2010/04/15 20:50:48, contributor wrote:
> > > On 2010/04/15 20:41:55, contributor wrote:
> > > > This line is too long.
> > > 
> > > Done.
> > 
> > Done.
> 
>

[Ojan Vafai]

Created attachment 53473 [details]
Patch

[Ojan Vafai]

Created attachment 53476 [details]
Patch

Feel free to provide comments at https://wkrietveld.appspot.com/3001

[Ojan Vafai]

Created attachment 53478 [details]
Patch-4001

Feel free to provide comments at https://wkrietveld.appspot.com/4001

[Julie Parent]

Comment on attachment 53478 [details]
Patch-4001

My comments from here
------------------------------------------------------------------
http://wkrietveld.appspot.com/4001/diff/1/4
File WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py (right):

http://wkrietveld.appspot.com/4001/diff/1/4#newcode4
WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py:4: # modification, are permitted provided that the following conditions are
Wot?

[David Levin]

Comment on attachment 53478 [details]
Patch-4001

test
------------------------------------------------------------------

[Ojan Vafai]

Created attachment 53577 [details]
Patch-5001