Bug 37510

Summary:

[RenderStyle Cleanup] Clean up StyleBackgroundData

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	oliver: review+

Dave Hyatt

Reported 2010-04-13 11:04:15 PDT

Clean up StyleBackgroundData (and also the member of RenderStyle of that type).

Attachments
Patch (15.39 KB, patch) 2010-04-13 11:04 PDT, Dave Hyatt	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2010-04-13 11:04:59 PDT

Created attachment 53265 [details] Patch

WebKit Review Bot

Comment 2 2010-04-13 11:06:22 PDT

Attachment 53265 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/rendering/style/RenderStyle.cpp:172: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/style/RenderStyle.cpp:505: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 3 2010-04-13 11:09:54 PDT

Comment on attachment 53265 [details] Patch r=me, style bot failures already exist and fixing them will just add more noise to the patch

Dave Hyatt

Comment 4 2010-04-13 11:11:01 PDT

Fixed in r57526.

Note You need to log in before you can comment on or make changes to this bug.