Bug 37510 - [RenderStyle Cleanup] Clean up StyleBackgroundData
Summary: [RenderStyle Cleanup] Clean up StyleBackgroundData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 11:04 PDT by Dave Hyatt
Modified: 2010-04-13 11:11 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.39 KB, patch)
2010-04-13 11:04 PDT, Dave Hyatt 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-04-13 11:04:15 PDT 
Clean up StyleBackgroundData (and also the member of RenderStyle of that type).
Comment 1 Dave Hyatt 2010-04-13 11:04:59 PDT 
Created attachment 53265 [details]
Patch
Comment 2 WebKit Review Bot 2010-04-13 11:06:22 PDT 
Attachment 53265 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/style/RenderStyle.cpp:172:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/style/RenderStyle.cpp:505:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2010-04-13 11:09:54 PDT 
Comment on attachment 53265 [details]
Patch

r=me, style bot failures already exist and fixing them will just add more noise to the patch
Comment 4 Dave Hyatt 2010-04-13 11:11:01 PDT 
Fixed in r57526.