Bug 37504

Summary: Change a parameter type of chooseIconForFiles()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: beidson, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Kent Tamura
Reported 2010-04-13 09:53:30 PDT
PassRefPtr<FileChoose> should be FileChoose*. Though some implementations of ChromeClient::chooseIconForFiles() might have ownership of the FileChooser instance, we don't need to use PassRefPtr<>. Such implementations can store the FileChooser pointer to RefPtr<FileChooser>.
Attachments
Proposed patch (16.52 KB, patch)
2010-04-13 12:44 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-04-13 12:44:23 PDT
Created attachment 53273 [details] Proposed patch
Kent Tamura
Comment 2 2010-04-13 12:46:38 PDT
Probably we want to change it for Chrome::runOpenPanel() too?
WebKit Commit Bot
Comment 3 2010-04-20 12:20:20 PDT
Comment on attachment 53273 [details] Proposed patch Clearing flags on attachment: 53273 Committed r57903: <http://trac.webkit.org/changeset/57903>
WebKit Commit Bot
Comment 4 2010-04-20 12:20:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.